Skip to content

Conversation

@cacharle
Copy link
Contributor

Fixes part of #585

@gemini-code-assist
Copy link

Summary of Changes

Hello @cacharle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the rfl library by adding the capability to convert field names from camelCase to snake_case, addressing a common requirement in data serialization. This new feature is integrated through a new CamelCaseToSnakeCase struct and is supported by a refactored and more unified internal case transformation mechanism. The changes improve flexibility for users dealing with different naming conventions and are thoroughly tested to ensure correctness and compatibility with existing features like field renaming.

Highlights

  • New Feature: CamelCaseToSnakeCase: Introduced a new utility rfl::CamelCaseToSnakeCase that automatically transforms struct field names from camelCase to snake_case during serialization and deserialization. This complements existing case conversion functionalities.
  • Internal Refactoring of Case Transformation: The internal case transformation logic has been refactored. The transform_snake_case.hpp header was renamed to transform_case.hpp and now houses a new transform_camel_case compile-time function, along with a is_upper helper, centralizing case conversion utilities.
  • New Test Case: A dedicated test file test_camel_case_to_snake_case_rename.cpp has been added to validate the new CamelCaseToSnakeCase functionality, ensuring it correctly handles field names and respects explicit renames using rfl::Rename.
  • Minor Optimization: An optimization was added to the to_camel_case function in strings.cpp by reserving string capacity, potentially improving performance for string manipulations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a CamelCaseToSnakeCase processor, which is a valuable addition. The refactoring to consolidate case transformation logic into a shared transform_case.hpp file is also a good improvement. I've identified a bug in the new transformation logic that results in incorrect conversions for fields starting with an uppercase letter, along with a couple of minor issues. My review includes specific suggestions to address these points.

cacharle and others added 2 commits January 27, 2026 21:44
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@liuzicheng1987 liuzicheng1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@liuzicheng1987
Copy link
Contributor

@cacharle thanks for the contribution. I am merging.

@liuzicheng1987 liuzicheng1987 merged commit c7a9741 into getml:main Jan 27, 2026
159 checks passed
@cacharle
Copy link
Contributor Author

Just realized I forgot to add anything to the doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants