Conversation
|
Also the void checks inside of the static asserts in the branches may be redundant given that the concept in the if constexpr already checks for that. |
|
Does Geode have a style guide for concept names? I named a concept |
|
looking at source it's inconsistent but mostly PascalCase |
I copied my implementation after testing it, it was named custom_modify_cast and I forgot to change the name back before PRing. Oops.
The original
modify_castwas only able to cast a non-modify class to a modify class.This pull request enables it to do the reverse, cast from a modify class to a non-modify class as well.
It also enables it to cast between 2 modify classes.