Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores a jQuery-based surface-pick callback path so that pickerfun provided to cortex.webgl.show(...) is invoked from Python when the user clicks on the surface in the WebGL viewer (fixing #598).
Changes:
- Update the
/pickerTornado handler to accept voxel coordinates asx,y,zplusvertexandhemi, and callpickerfun(voxel, vertex, hemi). - Add a default
PickPosition.prototype.callbackimplementation that triggers a GET to/pickeron each pick. - Update
show()’spickerfundocstring / default callback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
cortex/webgl/view.py |
Updates picker callback contract and server-side /picker argument parsing/callback invocation. |
cortex/webgl/resources/js/facepick.js |
Restores a jQuery $.get("/picker?...") request on picks by defining a default callback. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
8eabb16 to
43a256d
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the old jQuery mechanism from 77a24b5 . I don't know what the pros/cons are of this versus the
notifymechanism from legacy (3595800).Fixes #598 .