DRAFT: Add quick fix to rule82 (multi-fix)#656
Open
webwarrior-ws wants to merge 3 commits intofsprojects:masterfrom
Open
DRAFT: Add quick fix to rule82 (multi-fix)#656webwarrior-ws wants to merge 3 commits intofsprojects:masterfrom
webwarrior-ws wants to merge 3 commits intofsprojects:masterfrom
Conversation
webwarrior-ws
force-pushed
the
addQuickFixToRule82
branch
from
fa89efe to
be6dcb6
Compare
knocte
changed the title
xperiandri
requested changes
Jul 6, 2025
Collaborator
xperiandri
left a comment
xperiandri
left a comment
There was a problem hiding this comment.
I would prefer such syntax, otherwise good
xperiandri
force-pushed
the
addQuickFixToRule82
branch
from
bb881c2 to
00c5b02
Compare
Collaborator
|
Let's rebase this @webwarrior-ws |
Added tests for suggested quick fix for UsedUnderscorePrefixedElements rule.
webwarrior-ws
force-pushed
the
addQuickFixToRule82
branch
from
e8f435f to
0beb43d
Compare
Collaborator
|
CI is red. |
webwarrior-ws
force-pushed
the
addQuickFixToRule82
branch
from
91def21 to
cd5e497
Compare
Implement quick fix for UsedUnderscorePrefixedElements. Quick fix is only applied if no other identifiers with suggested name (without underscore) exist. There are cases when such identifiers exist, but not in the same scope, and stil no quick fix is applied. Co-authored-by: Mehrshad <code.rezaei@gmail.com>
webwarrior-ws
force-pushed
the
addQuickFixToRule82
branch
from
cc06cbf to
5403c27
Compare
Collaborator
|
Let's squash the last commit properly. |
Make ApplyQuickFix method apply all fixes and not only first one. It's necessary when testing rules that can create more than one suggested fix. Co-authored-by: Mehrshad <code.rezaei@gmail.com> Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
webwarrior-ws
force-pushed
the
addQuickFixToRule82
branch
from
92f3334 to
345c6b6
Compare
Contributor
Author
Squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement quick fix for
UsedUnderscorePrefixedElementsrule.It renames identifier with
_prefix to identifier without this prefix (e.g._foo->foo).Quick fix is only applied if no other identifiers with suggested name (without underscore) exist.
There are cases when such identifiers exist, but not in the same scope, and still no quick fix is applied. That is because checking the scope proved to be much more difficult than expected.