Conversation
Extract pipe-table and emacs-table parsing active patterns into a new MarkdownTableParser.fs (196 lines). MarkdownBlockParser.fs shrinks from 958 → 760 lines. MarkdownBlockParser now opens FSharp.Formatting.Markdown.TableParser to access PipeTableBlock and EmacsTableBlock. Part of #1022 (split large files). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dsyme
deleted the
repo-assist/fix-issue-1022-split-markdowntableparser-029a3ff14cab6b06
branch
nojaf
reviewed
Mar 9, 2026
|
|
||
| ### Refactored | ||
| * Split `MarkdownParser.fs` (1500 lines) into `MarkdownInlineParser.fs` (inline formatting) and `MarkdownParser.fs` (block-level parsing) for better maintainability. [#1022](https://github.com/fsprojects/FSharp.Formatting/issues/1022) | ||
| * Split pipe-table and Emacs-table parsing out of `MarkdownBlockParser.fs` into a new `MarkdownTableParser.fs` (196 lines), reducing `MarkdownBlockParser.fs` from 958 to 760 lines. [#1022](https://github.com/fsprojects/FSharp.Formatting/issues/1022) |
Collaborator
There was a problem hiding this comment.
Nitpick but I don't think this is worth communicating to end-users.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant, in response to a
/repo-assist continue pleasecommand from @dsyme on #1022.Closes #1022 (partial progress — continuing the file-splitting series)
Summary
Extracts the pipe-table and Emacs-table parsing code from
MarkdownBlockParser.fsinto a newMarkdownTableParser.fs, reducing the block parser from 958 → 760 lines.What was extracted into
MarkdownTableParser.fs(196 lines)pipeTableFindSplitsThese patterns are a natural cohesive unit (table-parsing) with no dependency on any function defined earlier in
MarkdownBlockParser.fs.MarkdownBlockParsernow simplyopensFSharp.Formatting.Markdown.TableParserto accessPipeTableBlockandEmacsTableBlock.Remaining large files (for follow-up)
BuildCommand.fsYaafFSharpScripting.fsSymbolReader.fsMarkdownBlockParser.fsTest Status
All 257 Markdown tests pass (
dotnet test tests/FSharp.Markdown.Tests/ --configuration Release). Build is clean with 0 warnings.