Better ESLint config

[kevinthecheung]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ESLint configuration to improve code quality and maintainability. It updates dependencies, introduces stylistic rules, and configures different ECMAScript versions for different file sets, ensuring a consistent coding style across the project.

Highlights

• ESLint Configuration Update: Refactored the ESLint configuration to use the recommended settings and stylistic plugins for better code quality and consistency.
• Dependency Updates: Updated ESLint and related dependencies, including adding @stylistic/eslint-plugin and removing eslint-config-google and @eslint/eslintrc.
• Code Style Rules: Enforced consistent code style rules such as linebreak-style, quotes, and semi using the @stylistic/eslint-plugin.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• eslint.config.mjs
  • Refactored ESLint configuration to use recommended settings and stylistic plugins.
  • Configured different ECMAScript versions for different file sets.
• package.json
  • Updated ESLint and related dependencies.
  • Added @stylistic/eslint-plugin and removed eslint-config-google and @eslint/eslintrc.
• pnpm-lock.yaml
  • Updated dependency versions to match changes in package.json.
  • Removed entries for eslint-config-google and @eslint/eslintrc and added entry for @stylistic/eslint-plugin.

Activity

• Updated ESLint configuration
• Refactored dependencies in package.json and pnpm-lock.yaml
• Introduced stylistic rules using @stylistic/eslint-plugin

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modernizes the ESLint configuration by moving to the flat config format and using the @stylistic/eslint-plugin for formatting rules. The changes are a good improvement, removing legacy compatibility layers and simplifying the setup. I've added a couple of suggestions to further refine the configuration for accuracy and strictness.

[gemini-code-assist]

Given this project's name is snippets-node, it seems to be a Node.js project. Including browser-specific globals might not be necessary and could hide potential errors (e.g., accidental usage of window or document). Consider removing ...globals.browser for stricter linting, unless you have browser-targeted code in this project.

Suggested change

	...globals.browser,
	// ...globals.browser,

[gemini-code-assist]

Node 18 has full support for ECMAScript 2022. It would be more accurate to set ecmaVersion to 2022 to allow for modern syntax features in your configuration file.

Suggested change

	ecmaVersion: 2021, // Node 18
	ecmaVersion: 2022, // Node 18