-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(firestore): Support for Firestore Pipeline APIs #18013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SelaseKay
wants to merge
27
commits into
feat/firestore-pipelines
Choose a base branch
from
feat-firestore-pipelines
base: feat/firestore-pipelines
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10,148
−518
Draft
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
90bd9b5
feat(firestore): add support for Pipeline APIs
SelaseKay 1c69d01
feat(firestore): implement pipeline execution and stages with options
SelaseKay 1094fd0
refactor: change PipelineSerializable to mixin and update Constant cl…
SelaseKay 89eb198
chore: add `Expression` functions
SelaseKay d92a2b0
chore: add support for Pigeon
SelaseKay b4089d8
chore: implement pipeline execution and expression parsing utilities …
SelaseKay 7d90353
chore: enhance PigeonPipelineResult to support nullable fields and ad…
SelaseKay 6fbd3e4
chore: enhance pipeline stage handling
SelaseKay 3e557c6
chore: refactor sorting functionality in pipeline stages to support m…
SelaseKay d3c2eeb
chore: implement iOS support for Firestore pipeline execution
SelaseKay b4f8466
Merge branch 'feat/firestore-pipelines' into feat-firestore-pipelines
SelaseKay d7bc27c
refactor: move aggregate classes to pipeline_aggregate.dart
SelaseKay 85d87e6
feat: enhance expression parsing in FLTPipelineParser to support addi…
SelaseKay 6699324
fix: update args type in _UnnestStage to use a more specific map type
SelaseKay 59c0b88
feat: add filter expression parsing to FLTPipelineParser for enhanced…
SelaseKay 642c0de
fix: handle null values in parseConstantValue
SelaseKay 0a06aea
feat: introduce keyForExpressionMap method in FLTPipelineParser for i…
SelaseKay 1b29c4d
feat: bump Firebase JS SDK to 12.9.0 (#18043)
SelaseKay fd07be0
fix: use builtin GITHUB_TOKEN instead of explicit secret (#18031)
morganchen12 fed585f
refactor(fdc): Support for entityId path extensions and hardening (#1…
aashishpatil-g 2334cf0
chore: fix formatting (#18044)
SelaseKay f2109de
Merge branch 'feat/firestore-pipelines' into feat-firestore-pipelines
SelaseKay dfab619
feat: implement Firestore pipeline support for web
SelaseKay 9061ea8
feat: enhance Firestore pipeline support for web
SelaseKay 00f23b4
fix
SelaseKay 26a9294
chore: clean up and refactor
SelaseKay b3d8e53
chore: add more interop and clean up code
SelaseKay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
PigeonPipelineResultclass definescreateTimeandupdateTimeas nullableLongs. Instead of setting them to0Lwhen the source timestamp is null, it would be more consistent to set them tonull. This avoids forcing the Dart side to treat0as a special case for a missing timestamp.