Skip to content

Include clientCache field during init#10077

Open
itsrakhil wants to merge 9 commits intofirebase:mainfrom
itsrakhil:caching
Open

Include clientCache field during init#10077
itsrakhil wants to merge 9 commits intofirebase:mainfrom
itsrakhil:caching

Conversation

@itsrakhil
Copy link
Contributor

Adds clientCache: {} to the generated SDK configurations for Web, Swift, Kotlin, and Dart when initialized via the Firebase CLI. This ensures that client-side caching is enabled by default for all newly created SDK configurations.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the initialization of client-side caching across various SDK configurations (Web, Swift, Kotlin, Dart) when generated through the Firebase CLI. By automatically including clientCache: {}, it ensures that new SDK setups benefit from client-side caching capabilities by default, improving performance and consistency for client applications.

Highlights

  • Default Client-Side Caching: Introduced clientCache: {} to the default configuration for Web, Swift, Kotlin, and Dart SDKs when initialized via the Firebase CLI.
  • Automated Caching Enablement: Ensured client-side caching is enabled by default for all newly created SDK configurations, improving performance and consistency.
  • Test Coverage Expansion: Updated unit tests to reflect the inclusion of clientCache in relevant SDK types and added a new test specifically for scenarios involving multiple SDK generations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/init/features/dataconnect/sdk.spec.ts
    • Added clientCache: {} to expected javascriptSdk, dartSdk, kotlinSdk, and swiftSdk configurations in various test scenarios.
    • Modified a test description to clarify that clientCache is not included for adminNodeSdk.
    • Introduced a new test case to verify that clientCache: {} is correctly added when generating multiple SDKs (Web and Dart).
  • src/init/features/dataconnect/sdk.ts
    • Added the clientCache: {} field to the default javascriptSdk configuration object.
    • Added the clientCache: {} field to the default dartSdk configuration object.
    • Added the clientCache: {} field to the default kotlinSdk configuration object.
    • Added the clientCache: {} field to the default swiftSdk configuration object.
Activity
  • No human activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds the clientCache: {} field to the generated SDK configurations for Web, Swift, Kotlin, and Dart platforms, ensuring client-side caching is enabled by default. The changes are well-implemented and include corresponding updates to the unit tests, correctly asserting the presence of clientCache for client SDKs and its absence for the Admin Node SDK. The code is clear and directly addresses the stated objective.

@fredzqm
Copy link
Contributor

fredzqm commented Mar 12, 2026

Let's add an experiment "fdcrealtime" here.

firebase init dataconnect:sdk should populate default value of client_cache (on by default).

@itsrakhil
Copy link
Contributor Author

Let's add an experiment "fdcrealtime" here.

firebase init dataconnect:sdk should populate default value of client_cache (on by default).

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants