fix: add invalid regex validation for commitConfig

[jescalada]

Fixes #1336.

Most of the changes are unit tests for the new code and /src/config/index.ts.

[netlify]

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name	Link
🔨 Latest commit	07da631
🔍 Latest deploy log	https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69908b288ba7a7000830f9b5

[codecov]

Codecov Report

❌ Patch coverage is 94.56522% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.51%. Comparing base (588d7f3) to head (07da631).
⚠️ Report is 20 commits behind head on main.

Files with missing lines	Patch %	Lines
src/config/validators.ts	93.65%	4 Missing ⚠️
src/config/ConfigLoader.ts	94.73%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
+ Coverage   81.25%   81.51%   +0.26%     
==========================================
  Files          65       66       +1     
  Lines        4657     4713      +56     
  Branches      792      814      +22     
==========================================
+ Hits         3784     3842      +58     
+ Misses        858      856       -2     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kriswest]

Possibly a double call to loadFullConfiguration that needs looking at

[kriswest]

This generally LGTM.

However, I can't help thinking about the fact we have multiple types of validation in different places (validation via the schema and quicktype during load, then this later). A slightly deeper refactor could combine those steps, parsing individual configs from strings using quicktype then applying other validators - resulting in a n easier to follow and maintain codebase..

I'm ok with merging in the current form and leaving such a refactor for later if you want to - hence approving.

[jescalada]

@kriswest Did some refactoring here, although not quite a full-blown refactor for the QuickType stuff. At least, the actual QuickType Convert.toGitProxyConfig call is in a more appropriate location (src/config/validators.ts).

I'd consider further refactoring if there's any extra feature requests or bugs in the ConfigLoader.

A final check is much appreciated 😃

[kriswest]

LGTM