Refactor: Use centralized hasOwnProperty utility functions#35864
Open
behnammodi wants to merge 1 commit intofacebook:mainfrom
Open
Refactor: Use centralized hasOwnProperty utility functions#35864behnammodi wants to merge 1 commit intofacebook:mainfrom
behnammodi wants to merge 1 commit intofacebook:mainfrom
Conversation
b406759 to
2434b99
Compare
|
Comparing: ab18f33...2434b99 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overview
This PR refactors property checking throughout the codebase to use centralized
hasOwnPropertyutility functions instead of directly accessingObject.prototype.hasOwnProperty.Changes
hasOwnPropertyfrom./utilshasOwnPropertyfrom./utilshasOwnPropertyfromshared/hasOwnPropertyinstead of defining locallyHow did you test this change?
yarn test --prod