fix: change private field from string to boolean#35863
fix: change private field from string to boolean#35863pickmemory wants to merge 1 commit intofacebook:mainfrom
Conversation
According to npm specification, private field must be boolean not string.
|
Hi @pickmemory! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
This PR fixes the malformed
privatefield inpackages/react-devtools-fusebox/package.json.Bug
The
privatefield was set to string"true"instead of booleantrue, which causes failures in package scanning tools that validate package metadata.Fix
Changed
"private": "true"to"private": trueRelated
privatefield in react-devtools-fusebox package.json #35793