Fix running all test-all jobs outside PRs#55917
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
Summary: As a defensive initial design, conditional Android/iOS job runs for `test-all` were intended to be scoped to PRs only, however required a missing `== 'true'` match specifier. Fixing this will help us catch rare integration-conflict failures on `main`, at the appropriate commit. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D95042221
meta-cla
bot
added
the
CLA Signed
cortinico
approved these changes
Mar 4, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 5, 2026
Summary: As a defensive initial design, conditional Android/iOS job runs for `test-all` were intended to be scoped to PRs only, however required a missing `== 'true'` match specifier. Fixing this will help us catch rare integration-conflict failures on `main`, at the appropriate commit. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D95042221
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 5, 2026
Summary: As a defensive initial design, conditional Android/iOS job runs for `test-all` were intended to be scoped to PRs only, however required a missing `== 'true'` match specifier. Fixing this will help us catch rare integration-conflict failures on `main`, at the appropriate commit. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D95042221
|
This pull request has been merged in 1f69a39. |
Collaborator
|
This pull request was successfully merged by @huntie in 1f69a39 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As a defensive initial design, conditional Android/iOS job runs for
test-allwere intended to be scoped to PRs only, however required a missing== 'true'match specifier.Fixing this will help us catch rare integration-conflict failures on
main, at the appropriate commit.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D95042221