fix: RCTViewComponentView can become first responder only when enableImperativeFocus flag is enabled#55908
Draft
war-in wants to merge 1 commit intofacebook:mainfrom
Draft
fix: RCTViewComponentView can become first responder only when enableImperativeFocus flag is enabled#55908war-in wants to merge 1 commit intofacebook:mainfrom
RCTViewComponentView can become first responder only when enableImperativeFocus flag is enabled#55908war-in wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In RN 0.83,
RCTViewComponentView.canBecomeFirstResponderwas changed to unconditionally returnYESas part of theenableImperativeFocusfeature. This causes UIKit to promote parent views to first responder after navigation transitions complete (via_promoteSelfOrDescendantToFirstResponderIfNecessary), stealing focus from text inputs and triggering an immediate focus→blur cycle.This fix gates
canBecomeFirstResponderbehind theenableImperativeFocusfeature flag (which defaults to false), so views only become eligible for first responder when imperative focus is actually enabled.Changelog:
[IOS] [FIXED] - Fixed RCTViewComponentView unconditionally returning YES from canBecomeFirstResponder, which caused focus to be stolen from text inputs after navigation transitions
Test Plan: