Babel preset: Add unstable_preserveClassPrivate to experiment with disabling private class transforms for SH#55880
Open
Babel preset: Add unstable_preserveClassPrivate to experiment with disabling private class transforms for SH#55880
Conversation
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
…sabling private class transforms for SH (#55880) Summary: Disable `babel/plugin-transform-private-methods` and `babel/plugin-transform-private-property-in-object` when `customTransformOptions.unstable_preserveClassPrivate` is truthy. This allows us to experiment with native private class field and method support in Static Hermes. Changelog: [Internal] Reviewed By: vzaidman, javache Differential Revision: D93010263
448c679 to
c1b11df
Compare
…sabling private class transforms for SH (#55880) Summary: Pull Request resolved: #55880 Disable `babel/plugin-transform-private-methods` and `babel/plugin-transform-private-property-in-object` when `customTransformOptions.unstable_preserveClassPrivate` is truthy. This allows us to experiment with native private class field and method support in Static Hermes. Changelog: [Internal] Reviewed By: vzaidman, javache Differential Revision: D93010263
c1b11df to
91d9289
Compare
Collaborator
|
This pull request was successfully merged by @robhogan in 91d9289 When will my fix make it into a release? | How to file a pick request? |
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Disable
babel/plugin-transform-private-methodsandbabel/plugin-transform-private-property-in-objectwhencustomTransformOptions.unstable_preserveClassPrivateis truthy. This allows us to experiment with native private class field and method support in Static Hermes.Changelog: [Internal]
Reviewed By: vzaidman, javache
Differential Revision: D93010263