Skip to content

Comments

Remove deprecated ShadowNode type aliases#55687

Open
sammy-SC wants to merge 2 commits intofacebook:mainfrom
sammy-SC:export-D90331085
Open

Remove deprecated ShadowNode type aliases#55687
sammy-SC wants to merge 2 commits intofacebook:mainfrom
sammy-SC:export-D90331085

Conversation

@sammy-SC
Copy link
Contributor

Summary:

Changelog:

[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:

  • ShadowNode::Shared → use std::shared_ptr<const ShadowNode>
  • ShadowNode::Weak → use std::weak_ptr<const ShadowNode>
  • ShadowNode::Unshared → use std::shared_ptr<ShadowNode>
  • ShadowNode::ListOfShared → use std::vector<std::shared_ptr<const ShadowNode>>
  • ShadowNode::ListOfWeak → use std::vector<std::weak_ptr<const ShadowNode>>

Reviewed By: lenaic

Differential Revision: D90331085

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 23, 2026

@sammy-SC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90331085.

sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 23, 2026
Summary:

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 23, 2026
Summary:

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 23, 2026
Summary:

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 23, 2026
Summary:
Pull Request resolved: facebook#55687

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 23, 2026
Summary:

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 23, 2026
Summary:

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 23, 2026
Summary:

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 23, 2026
Summary:

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
Summary:

changelog: [internal]

Small cleanup in UIManager

Reviewed By: lenaic

Differential Revision: D90330663
Summary:

## Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.

Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
- `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>`
- `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>`
- `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>`
- `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>`
- `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>`

Reviewed By: lenaic

Differential Revision: D90331085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants