Skip to content

Fix minor issues in UIManager #55686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammy-SC wants to merge 1 commit into from
+6 −9
Closed

Fix minor issues in UIManager #55686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ void UIManager::setNativeProps_DEPRECATED(
->getProps(),
RawProps(rawProps));

return oldShadowNode.clone({/* .props = */ .props = props});
return oldShadowNode.clone({.props = props});
});

return std::static_pointer_cast<RootShadowNode>(rootNode);
Expand All @@ -493,15 +493,12 @@ void UIManager::configureNextLayoutAnimation(
const jsi::Value& failureCallback) const {
if (animationDelegate_ != nullptr) {
animationDelegate_->uiManagerDidConfigureNextLayoutAnimation(
runtime,
config,
std::move(successCallback),
std::move(failureCallback));
runtime, config, successCallback, failureCallback);
}
}

static std::shared_ptr<const ShadowNode> findShadowNodeByTagRecursively(
std::shared_ptr<const ShadowNode> parentShadowNode,
const std::shared_ptr<const ShadowNode>& parentShadowNode,
Tag tag) {
if (parentShadowNode->getTag() == tag) {
return parentShadowNode;
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class UIManager final : public ShadowTreeDelegate {
std::weak_ptr<UIManagerAnimationBackend> unstable_getAnimationBackend();

/**
* Execute stopSurface on any UIMAnagerAnimationDelegate.
* Execute stopSurface on any UIManagerAnimationDelegate.
*/
void stopSurfaceForAnimationDelegate(SurfaceId surfaceId) const;

Expand All @@ -79,9 +79,9 @@ class UIManager final : public ShadowTreeDelegate {
void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);

/*
* Provides access to a UIManagerBindging.
* Provides access to a UIManagerBinding.
* The `callback` methods will not be called if the internal pointer to
* `UIManagerBindging` is `nullptr`.
* `UIManagerBinding` is `nullptr`.
* The callback is called synchronously on the same thread.
*/
void visitBinding(
Expand Down
Loading