Move ShadowNodeFamily to PropsAnimatedNode #54879
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89042963. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
facebook-github-bot
force-pushed
the
export-D89042963
branch
from
db07a35 to
51a8e87
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
facebook-github-bot
force-pushed
the
export-D89042963
branch
from
51a8e87 to
04164e6
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
facebook-github-bot
force-pushed
the
export-D89042963
branch
from
04164e6 to
2dd4f6a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
facebook-github-bot
force-pushed
the
export-D89042963
branch
2 times, most recently
from
7fce959 to
048ed2b
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
facebook-github-bot
force-pushed
the
export-D89042963
branch
from
048ed2b to
6e96106
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
facebook-github-bot
force-pushed
the
export-D89042963
branch
2 times, most recently
from
cbac506 to
57ba558
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: facebook#54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: #54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
force-pushed
the
export-D89042963
branch
from
57ba558 to
4560c9a
Compare
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in d91de96 When will my fix make it into a release? | How to file a pick request? |
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: facebook#54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: #54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: #54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
force-pushed
the
export-D89042963
branch
from
4560c9a to
8267a59
Compare
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in 8267a59 When will my fix make it into a release? | How to file a pick request? |
Collaborator
|
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 17, 2025
Summary: Pull Request resolved: facebook#54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 17, 2025
Summary: Pull Request resolved: #54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
force-pushed
the
export-D89042963
branch
from
8267a59 to
9227dd7
Compare
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in 9227dd7 When will my fix make it into a release? | How to file a pick request? |
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 18, 2025
Summary: Pull Request resolved: #54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 18, 2025
Summary: Pull Request resolved: #54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
force-pushed
the
export-D89042963
branch
from
9227dd7 to
93f7feb
Compare
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in 93f7feb When will my fix make it into a release? | How to file a pick request? |
Job Summary for GradleTest All :: run_fantom_tests
|
facebook-github-bot
force-pushed
the
export-D89042963
branch
from
93f7feb to
f7bfde4
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 19, 2025
Summary: Pull Request resolved: #54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 19, 2025
Summary: Pull Request resolved: #54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
bartlomiejbloniarz
force-pushed
the
export-D89042963
branch
from
f7bfde4 to
daee5a4
Compare
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in daee5a4 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
force-pushed
the
export-D89042963
branch
from
daee5a4 to
7822032
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Reviewed By: zeyap Differential Revision: D89042963
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Reviewed By: zeyap Differential Revision: D89042963
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. # Changelog [General] [Added] - `connectToShadowNodeFamily` and `disconnectFromShadowNodeFamily` methods in PropsAnimatedNode [General] [Changed] - Moved `shadowNodeFamily_` from a map in `NativeAnimatedNodesManager` to `PropsAnimatedNode` Reviewed By: lenaic, zeyap Differential Revision: D89042963
bartlomiejbloniarz
force-pushed
the
export-D89042963
branch
from
7822032 to
0e41c22
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Jan 7, 2026
Summary: Pull Request resolved: facebook#54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup
tagToShadowNodeFamily_when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that.Differential Revision: D89042963