Add synchronous updates to the AnimatedPropsRegistry #54878
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89042934. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
db1b4c1 to
b6279e4
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
b6279e4 to
02bc1b8
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
02bc1b8 to
6d08631
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
2 times, most recently
from
019e9a1 to
e0e941a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Reviewed By: zeyap Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
e0e941a to
566984f
Compare
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: #54878 This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Reviewed By: zeyap Differential Revision: D89042934
bartlomiejbloniarz
force-pushed
the
export-D89042934
branch
from
566984f to
eb7b4dd
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Reviewed By: zeyap Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
eb7b4dd to
0e02cea
Compare
Collaborator
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 17, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Reviewed By: zeyap Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
0e02cea to
4092f27
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 17, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Reviewed By: zeyap Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
4092f27 to
c56f079
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Reviewed By: zeyap Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
c56f079 to
15f77cd
Compare
added 3 commits
December 19, 2025 02:26
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
Summary: This diff simply extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Reviewed By: zeyap Differential Revision: D89042934
facebook-github-bot
force-pushed
the
export-D89042934
branch
from
15f77cd to
5ee1137
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Reviewed By: zeyap Differential Revision: D89042934
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. # Changelog [General] [Changed] - AnimatedPropsRegistry now also receive the updates from the synchronous updates that bypass the ShadowTree, so that these updates are not overwritten by React commits Reviewed By: zeyap Differential Revision: D89042934
|
This pull request has been merged in c52d30e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path.
Differential Revision: D89042934