-
Notifications
You must be signed in to change notification settings - Fork 25k
Add test for width, height and opacity #54873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for width, height and opacity #54873
Conversation
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85753518. |
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
ad7c5e3 to
5d8b217
Compare
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
5d8b217 to
185db6c
Compare
Summary: This diff simple extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
185db6c to
dceb4fb
Compare
|
Summary: This diff simple extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
Summary: This diff simple extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
dceb4fb to
6a951d6
Compare
Summary: This diff simply extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
Summary: This diff simply extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
Summary: This diff simply extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
…54872) Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. # Changelog [General] [Changed] - C++ animated now passes the calculated `folly::dynamic` directly to the backend, without repacking it into `AnimatedProp` Reviewed By: zeyap Differential Revision: D88743857
Summary: This diff simply extends the tests for AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
6a951d6 to
33b47e3
Compare
Summary: This diff simply extends the tests for AnimationBackend # Changelog [General] [Added] - A new test for the AnimationBackend Reviewed By: zeyap Differential Revision: D85753518
|
This pull request was successfully merged by Bartlomiej Bloniarz in 8bc6214 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 8bc6214. |
Summary: This diff simple extends the tests for AnimationBackend
Differential Revision: D85753518