Use dynamic for updates in Animated with Animation Backend #54872
+83
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88743857. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
bartlomiejbloniarz
force-pushed
the
export-D88743857
branch
from
e79cccc to
8b084dc
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 16, 2025
…54872) Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
bartlomiejbloniarz
force-pushed
the
export-D88743857
branch
from
8b084dc to
83082b8
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 16, 2025
…54872) Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
bartlomiejbloniarz
force-pushed
the
export-D88743857
branch
from
83082b8 to
f3d0f8f
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 17, 2025
…54872) Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 17, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 18, 2025
…54872) Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
bartlomiejbloniarz
force-pushed
the
export-D88743857
branch
from
f3d0f8f to
72004a7
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
…54872) Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
bartlomiejbloniarz
force-pushed
the
export-D88743857
branch
from
72004a7 to
564c7ec
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Reviewed By: zeyap Differential Revision: D88743857
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 19, 2025
…54872) Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. # Changelog [General] [Changed] - C++ animated now passes the calculated `folly::dynamic` directly to the backend, without repacking it into `AnimatedProp` Reviewed By: zeyap Differential Revision: D88743857
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in 84e408c When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 84e408c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use
folly::dynamicagain.Differential Revision: D88743857