Handle tcache init failures gracefully#81
Merged
guangli-dai merged 1 commit intofacebook:devfrom Mar 9, 2026
Merged
Conversation
lexprfuncall
force-pushed
the
fix-tcache-init
branch
from
cf04184 to
e9307ec
Compare
spredolac
reviewed
Mar 4, 2026
spredolac
approved these changes
Mar 4, 2026
lexprfuncall
force-pushed
the
fix-tcache-init
branch
from
e9307ec to
5f53c87
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
lexprfuncall
force-pushed
the
fix-tcache-init
branch
2 times, most recently
from
44fc3f4 to
ae74bf2
Compare
tsd_tcache_data_init() returns true on failure but its callers ignore this return value, leaving the per-thread tcache in an uninitialized state after a failure. This change disables the tcache on an initialization failure and logs an error message. If opt_abort is true, it will also abort. New unit tests have been added to test tcache initialization failures.
lexprfuncall
force-pushed
the
fix-tcache-init
branch
from
ae74bf2 to
0a6b44c
Compare
guangli-dai
approved these changes
Mar 9, 2026
|
Discussed offline, now that we have exposed the boolean value for utility functions, sorting out the error message for the mallctl is another task and will be followed up in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsd_tcache_data_init initializes the per-thread tcache and returns true on failure but, currently, its callers ignore this return value and will proceed with an uninitialized tcache following an failure.
This change updates all of its callers to check for init failure and print an error message. If opt_abort is set, it will also abort immediately. Otherwise, it simply disables the tcache for that thread and returns an error.
Also, unit tests have been added to cover both the abort and non-abort paths. To make failures testable, tcache_stack_alloc was refactored into a function pointer so tests can swap-in an allocator stub that always fails.