NUMA bindigs support for private memory#195
Open
vinser52 wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
Author
|
Hi @therealgymmy, could you please take a look at this PR? It was opened more than a month ago. |
5f981f0 to
2f5c0be
Compare
Contributor
|
@vinser52: apologies for the late review. Instead of supporting this, I think we should deprecate private memory altogether. Today when a cachelib user has configued memory-monitor (where we may madvise away pages to make more memory available for the rest of the system), we will always use SHM. This means we will just support Shm for multi-tier memory, and internally we can start moving everyone off private memory mode. https://github.com/facebook/CacheLib/blob/main/cachelib/allocator/CacheAllocator-inl.h#L53-L54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds NUMA binding support for private memory. I tried to align the implementation with shared memory approach and introduced
PrivateMemoryManager. By current design,SlabAllocatorallocates and owns private memory but shared memory is supplied as external memory toSlabAllocator. With this PR the memory is always supplied as external toSlabAllocatorand probably we have to clean upSlabAllocatorimplementation because it is not required to own memory anymore.