Add Linux ARM64 GNU fallback support for Android ARM64#56
Add Linux ARM64 GNU fallback support for Android ARM64#56
Conversation
On Android, process.platform returns 'android' instead of 'linux', so the NAPI-RS generated loader looks for android-specific binaries that don't exist. Since Android is Linux under the hood, the Linux arm64 GNU binary works fine. Changes: - index.js: Add fallback to linux-arm64-gnu binary in the Android arm64 path - npm/linux-arm64-gnu/package.json: Add 'android' to os array so npm installs the linux-arm64-gnu package on Android devices https://claude.ai/code/session_015zso6wY1hJMst67LiXp4LW
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR adds fallback support for loading Linux ARM64 GNU native binaries on Android ARM64 platforms. Since Android is Linux-based under the hood, the Linux ARM64 GNU binary can serve as a fallback when Android-specific binaries are not available.
Key Changes
index.jshypersync-client.linux-arm64-gnu.node) on Android ARM64 platforms@envio-dev/hypersync-client-linux-arm64-gnunpm package with version validation (expects version 1.1.0)npm/linux-arm64-gnu/package.jsonto declare support for bothlinuxandandroidoperating systemsImplementation Details
NAPI_RS_ENFORCE_VERSION_CHECKenvironment variable to ensure compatibilityhttps://claude.ai/code/session_015zso6wY1hJMst67LiXp4LW