Use consistent include order in our standard headers. NFC#26434
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Use consistent include order in our standard headers. NFC#26434sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
changed the title
sbc100
commented
Mar 11, 2026
brendandahl
reviewed
Mar 11, 2026
sbc100
changed the title
brendandahl
reviewed
Mar 11, 2026
brendandahl
approved these changes
Mar 11, 2026
This change was generated using: ``` clang-tidy -checks='llvm-include-order' -fix-errors -fix system/include/emscripten/*.h -- -x c++-header -std=c++17 --sysroot=cache/sysroot --target=wasm32-emscripten -iwithsysroot/include/compat ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was generated using:
I also manually split the headers such that the internal emscripten headers always come first a group before any system headers.
This change initially resulted in the failure of
test_em_js_bool_macro_expansionwhich required that addition ofstdbool.htoem_js.h.