Move low level lock/condvar/semaphore form libwasm_worker to libc.#26433
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 11, 2026
Merged
Move low level lock/condvar/semaphore form libwasm_worker to libc.#26433sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
changed the title
sbc100
force-pushed
the
wasm_worker_locks
branch
2 times, most recently
from
cf5bb23 to
4ffbf0f
Compare
I've moved the declarations of these functions to a new header (`threading_primitives.h`) which is then included in both `wasm_workers.h` and in `threading.h`. Add a some basic testing that these function are available under pthreads as well as wasm workers.
sbc100
force-pushed
the
wasm_worker_locks
branch
from
4ffbf0f to
4ef711e
Compare
Collaborator
Author
|
Also TIL one can confirm the moved code is unmodified using |
kripken
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've moved the declarations of these functions to a new header (
threading_primitives.h) which is then included in bothwasm_workers.hand inthreading.h.Add a some basic testing that these function are available under pthreads as well as wasm workers.
This is step towards using these primitives to make implement libc++'s mutex/cond helpers needed for
call_once. See #26375.All the declaration and implementations here are unchanged: This is a pure move.