Skip to content

Fix: writeI53ToI64 crashes with -sASSERTIONS=2 when num >= 2^32 #26410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
49iohcy wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix: writeI53ToI64 crashes with -sASSERTIONS=2 when num >= 2^32 #26410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/libint53.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ addToLibrary({
// function $writeI53ToU64(): the implementation would be identical, and it is up to the
// C/C++ side code to interpret the resulting number as signed or unsigned as is desirable.
$writeI53ToI64: (ptr, num) => {
{{{ makeSetValue('ptr', 0, 'num', 'u32') }}};
{{{ makeSetValue('ptr', 0, 'num&0xFFFFFFFF', 'u32') }}};
Copy link
Collaborator

@sbc100 sbc100 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we normally write this as num >>> 0

Copy link
Author

@49iohcy 49iohcy Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I'll see what I can do with the test and let you know!

var lower = {{{ makeGetValue('ptr', 0, 'u32') }}};
{{{ makeSetValue('ptr', 4, '(num - lower)/4294967296', 'u32') }}};
#if ASSERTIONS
Expand Down