Fix symlink support in IDBFS#26408
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 7, 2026
Merged
Conversation
brendandahl
approved these changes
Mar 6, 2026
sbc100
force-pushed
the
test_idbfs_autopersist
branch
from
8ec9f49 to
b9f1a1d
Compare
Collaborator
Author
|
Actually it turned out that the fix wasn't too hard.. so this change now just fixes the issue! |
sbc100
changed the title
sbc100
force-pushed
the
test_idbfs_autopersist
branch
2 times, most recently
from
0952577 to
a78f496
Compare
Previously symlinks would be followed when saving to IBDFS and then restored as essentially duplicates of the files they pointed to. Fixes: emscripten-core#26407
sbc100
force-pushed
the
test_idbfs_autopersist
branch
from
a78f496 to
ed47309
Compare
Collaborator
Author
|
Landing with actual fix TBR since this is currently blocking #26398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously symlinks would be followed when saving to IBDFS and then
restored as essentially duplicates of the files they pointed to, which is
not correct.
Fixes: #26407