Skip to content

Conversation

@aheejin
Copy link
Member

@aheejin aheejin commented Jan 6, 2026

Additional change:

  • StackSizeIsUnlimited in lib/sanitizer_common/sanitizer_posix_libcdep.cpp was excluded from Emscripten build along with several other methods in Fix asan.test_asyncify_longjmp #20740. A new call to StackSizeIsUnlimited was added in lib/asan/asan_rtl.cpp in this version, so this excludes the call too.

`StackSizeIsUnlimited` in
`lib/sanitizer_common/sanitizer_posix_libcdep.cpp` was excluded from
Emscripten build along with several other methodsin emscripten-core#20740, presumably
because they call `setrlimit` and `getrlimit`. A new call to
`StackSizeIsUnlimited` was added in `lib/asan/asan_rtl.cpp` in this
version, so this excludes the call too.
@aheejin aheejin requested a review from sbc100 January 6, 2026 21:40
This is an automatic change generated by tools/maint/rebaseline_tests.py.

The following (1) test expectation files were updated by
running the tests with `--rebaseline`:

```
codesize/test_codesize_hello_dylink_all.json: 819075 => 822630 [+3555 bytes / +0.43%]

Average change: +0.43% (+0.43% - +0.43%)
```
@aheejin
Copy link
Member Author

aheejin commented Jan 6, 2026

Currently these tests sometimes hang:

asan.test_asyncify_indirect_lists_normal
asan.test_asyncify_indirect_lists_add_no_prop
asan.test_async_loop
asan.test_asyncify_indirect_lists_add
asan.test_asyncify_assertions
asan.test_async_hello
asan.test_async_ccall_promise_jspi
asan.test_async_ccall_good

But this happens in the 'main' branch too, so these look irrelevant.

Also these tests fail, but also in the main branch:

asan.test_esm_integration
lsan.test_esm_integration
asan.test_esm_integration_main
asan.test_esm_integration_main_imported_memory

It looks these need to be skipped with sanitizers: #26043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant