[contrib.lua] Upgraded lua to new version 5.5.0 #26033
Merged
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jan 3, 2026
| ldblib.c liolib.c lmathlib.c loadlib.c loslib.c lstrlib.c ltablib.c lutf8lib.c linit.c | ||
| '''.split() | ||
|
|
||
| flags = ['-DLUA_COMPAT_5_3'] |
Contributor
Author
There was a problem hiding this comment.
This flag doesn't exist anymore so it's useless to leave it
Collaborator
There was a problem hiding this comment.
Do you know why it was being used previously?
Contributor
Author
There was a problem hiding this comment.
My understanding is that when they upgraded to 5.4 this flag was being used to still enable what was being deprecated/removed from 5.3. With the release of 5.5 it's truly removed so there's no way to reenable it, so the flag is gone. As I pointed out there is no such equivalent flag for 5.4
sbc100
approved these changes
Jan 3, 2026
Contributor
Author
|
After merging/rerunning the tests. All green. |
Contributor
Author
Collaborator
|
It looks like you added a changelog entry under |
Contributor
Author
|
🤦 .... alright I will fix that |
Contributor
Author
|
Done... #26059 |
sbc100
pushed a commit
that referenced
this pull request
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded lua to new version 5.5.0
Note that there is no
LUA_COMPAT_5_4flag...