Open
Conversation
1fbd5e6 to
43ddd16
Compare
7d2ad1c to
e4accab
Compare
Member
|
I'd like to get out this upcoming bug fix release before we make a big change just to make sure we have time to test for regressions :) |
Member
Author
|
Ah yes I agree I actually wanted to say that somewhere but I forgot :| |
e4accab to
c0dec15
Compare
This was referenced Dec 24, 2025
Open
|
I tested this change, and the "Backgound Apps" group is always shown, even if there are no background apps currently. I do not think it should be the case. |
|
Can you apply this patch @leolost2605 ? Its to restore the background_item hiding/reappearing when background apps are removed/added diff --git a/src/ItemManager.vala b/src/ItemManager.vala
index a1981d56..d65137d3 100644
--- a/src/ItemManager.vala
+++ b/src/ItemManager.vala
@@ -24,10 +24,14 @@
launchers = new ListStore (typeof (Launcher));
background_item = new BackgroundItem ();
- background_item.apps_appeared.connect (add_item);
+ background_item.apps_appeared.connect (() => append (background_item));
+ background_item.removed.connect (() => {
+ if (!background_item.has_apps) {
+ remove (background_item);
+ }
+ });
append (new ItemGroup (launchers));
- append (background_item);
overflow = VISIBLE;
`` |
c0dec15 to
95feed3
Compare
Member
Author
|
@flodavid I think with your patch the background item would be at the end instead of where it's on main but it should be fixed now (I added an item group just for the background item to also make sure it gets smooth reveal/hide animation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having one big Gtk.Fixed with all of the launchers, separator, workspace, etc. introduce an ItemGroup class which holds the items of one group and add them together in a gtk.box. The ItemGroup works with a listmodel.
This has a couple advantages.
To reduce the diff the listmodels are still in the main itemmanager and just relay the current mechanisms to the item group via the listmodel. Therefore the following points will be for the future: