Ensure correct focus configuration for Element Call before allowing users to call. #31490
+293
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
approved these changes
Jan 5, 2026
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
Nit: one focus, multiple foci :)
robintown
reviewed
Jan 8, 2026
src/utils/room/placeCall.ts
Outdated
Comment on lines
29
to
31
| platformCallType: PlatformCallType, | ||
| platformCallType: PlatformCallType | undefined, | ||
| skipLobby: boolean | undefined, | ||
| voiceOnly: boolean, | ||
| voiceOnly: boolean | undefined, |
Member
There was a problem hiding this comment.
What does it mean for the call type or voice-only to be undefined?
Member
Author
There was a problem hiding this comment.
Not sure, I think this is probably accidental.
src/stores/CallStore.ts
Outdated
Comment on lines
51
to
52
| * This ensures we only fetch transport information once during the lifetime | ||
| * of a session. |
| test.use({ | ||
| synapseConfig: { | ||
| experimental_features: { | ||
| msc4143_enabled: false, |
Member
There was a problem hiding this comment.
Is this here to be testing the .well-known fallback instead?
Comment on lines
+74
to
+75
| default: | ||
| throw Error(`Unexpected PlatformCallType ${platformCallType}`); |
Member
There was a problem hiding this comment.
🤔 Why accept an undefined call type if it's an error?
Member
Author
There was a problem hiding this comment.
The undefined doesn't make sense, and I'll fix that. The error still makes sense to ensure we don't end up doing undefined things if platformCallType was not an expected value at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently anyone who enables Element Call via
feature_group_callscan start an Element Call, but that is not enough to actually succeed. You need to have a focus configured on your server to do that, and so we should prevent users stumbling into this without first having foci configured.Note, joining a call may be done by anothers focus presently so it's not required to have this config to join another call.