Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the EIC container Spack environment to use Acts v45.1.1, aligning the pinned Acts version with the upstream Spack package definition updates referenced in #166.
Changes:
- Add upstream
spack/spack-packagescherry-picks needed to introduce Acts v45.x versions and improved variant dependency handling. - Update
spack-environment/packages.yamlto requireacts@45.1.1(keeping the existing variant set).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
spack-packages.sh |
Adds the upstream cherry-pick commits that introduce Acts v45.0.0 / v45.1.0 / v45.1.1 and variant dependency handling updates. |
spack-environment/packages.yaml |
Pins Acts from @44.4.0 to @45.1.1 under package requirements. |
wdconinc
force-pushed
the
acts-45.1.1
branch
from
187890b to
a3346be
Compare
wdconinc
force-pushed
the
acts-45.1.1
branch
from
a3346be to
34bbdf2
Compare
wdconinc
force-pushed
the
acts-45.1.1
branch
from
34bbdf2 to
cbe2f99
Compare
Member
|
Physics benchmarks are unhappy: |
Contributor
Author
|
Yeah. Fixed in then Gen1/Gen3 geometry branch... Need to extract and apply cleanly. |
Contributor
Author
Actually, this is already fixed (eic/EICrecon#2466). It just doesn't retroactively appear in the latest released EICrecon that's used in the default workflow (and nightly succeeded). So this is effectively on hold until the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Needs:
This PR update
actsto v45.1.1. Follows #166 with correct branch name. Juggler gets a minor upgrade to make sure it can handle the updated interfaces in Acts v45.