fix: Many fixes for enterprise IDAs #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
commented
May 13, 2025
|
|
||
| dev.shell.%: ## Run a shell on the specified service's container. | ||
| docker compose exec $* /bin/bash | ||
| docker compose exec -u 0 $* /bin/bash |
Member
Author
There was a problem hiding this comment.
We need to be logging developers into the containers as root, NOT as the unprivileged app user. Without root, you're basically helpless as you can't install custom requirements and other basic things like run management commands from the shell.
We've been doing this in the various Makefiles in the enterprise-* repos since forever.
pwnage101
force-pushed
the
pwnage101/enterprise-catalog-better-support
branch
4 times, most recently
from
094816d to
6164812
Compare
pwnage101
commented
May 13, 2025
| - ${DEVSTACK_WORKSPACE}/enterprise-access:/edx/app/enterprise-access/ | ||
| - ${DEVSTACK_WORKSPACE}/src:/edx/src | ||
| - ${PWD}/py_configuration_files/enterprise_access.py:/edx/app/enterprise-access/license_manager/settings/devstack.py | ||
| - ${PWD}/py_configuration_files/enterprise_access.py:/edx/app/enterprise-access/enterprise_access/settings/devstack.py |
pwnage101
force-pushed
the
pwnage101/enterprise-catalog-better-support
branch
from
6164812 to
104bab7
Compare
It seems like the various enterprise-specific devstack settings are a mix of legacy stuff combined with failed attempts to port repo-specific devstack configs into this central devstack repo. As a result, the various hostnames and paths are completely broken. This hasn't impacted us because we normally don't use enterprise inside of devstack, but this is will hopefully be our future.
pwnage101
force-pushed
the
pwnage101/enterprise-catalog-better-support
branch
from
104bab7 to
81c0238
Compare
brobro10000
approved these changes
May 14, 2025
adamstankiewicz
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the various enterprise-specific devstack settings are a mix of legacy stuff combined with failed attempts to port repo-specific devstack configs into this central devstack repo. As a result, the various hostnames and paths are completely broken. This hasn't impacted us because we normally don't use enterprise inside of devstack, but this is will hopefully be our future.