refactor(common): replace CatalogTable with tuple type#1908
Open
refactor(common): replace CatalogTable with tuple type#1908
CatalogTable with tuple type#1908Conversation
LNSD
force-pushed
the
lnsd/refactor-common-catalog-physical
branch
from
498e962 to
d68d45c
Compare
…str>) tuples Remove the thin wrapper struct in favor of raw tuples, reducing indirection for a type with no logic beyond two trivial accessors. - Delete `CatalogTable` struct and its `new`, `physical_table`, `sql_schema_name` methods - Change `Catalog::entries` field and all related signatures to `Vec<(Arc<PhysicalTable>, Arc<str>)>` - Update `CatalogSnapshot::from_catalog` and `catalog_entries` to the tuple type - Replace all `CatalogTable::new(...)` construction sites with tuple literals - Use destructuring at all access sites instead of named accessor calls Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-common-catalog-physical
branch
from
d68d45c to
720316c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the thin wrapper struct in favor of raw tuples, reducing indirection for a type with no logic beyond two trivial accessors.
CatalogTablestruct and itsnew,physical_table,sql_schema_namemethodsCatalog::entriesfield and all related signatures toVec<(Arc<PhysicalTable>, Arc<str>)>CatalogSnapshot::from_catalogandcatalog_entriesto the tuple typeCatalogTable::new(...)construction sites with tuple literals