refactor(datasets-derived): validate functions at deserialization#1905
Open
refactor(datasets-derived): validate functions at deserialization#1905
Conversation
LNSD
force-pushed
the
lnsd/refactor-datasets-derived-func-validate
branch
2 times, most recently
from
1f1cb30 to
ca4cccf
Compare
Contributor
Author
|
This is another spin-off from #1900 |
LNSD
force-pushed
the
lnsd/refactor-datasets-derived-func-validate
branch
from
ca4cccf to
3c19bec
Compare
mitchhs12
reviewed
Mar 4, 2026
mitchhs12
reviewed
Mar 4, 2026
Decouple `datasets-derived` from `ScalarUDF` and `js-runtime` by moving Arrow type validation to the deserialization boundary, so a successfully deserialized `Function` is always valid. - Move `Function`/`FunctionSource` from `datasets-common` into `datasets-derived` with custom `Deserialize` that validates Arrow types against JS UDF-supported primitives - Remove `js-runtime` dependency from `datasets-derived`; `Dataset::function_by_name` returns `&Function` instead of constructing `ScalarUDF` - Simplify `SelfSchemaProvider::from_manifest_udfs` by removing redundant `schema_name` parameter Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-datasets-derived-func-validate
branch
from
3c19bec to
0937306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple
datasets-derivedfromScalarUDFandjs-runtimeby moving Arrow type validation to the deserialization boundary, so a successfully deserializedFunctionis always valid.Function/FunctionSourcefromdatasets-commonintodatasets-derivedwith customDeserializethat validates Arrow types against JS UDF-supported primitivesjs-runtimedependency fromdatasets-derived;Dataset::function_by_namereturns&Functioninstead of constructingScalarUDFSelfSchemaProvider::from_manifest_udfsby removing redundantschema_nameparameter