cli: simplify npm binary setup #837
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
force-pushed
the
cli-simple-bin
branch
2 times, most recently
from
97cc135 to
ad0466b
Compare
This commit moves `ovsx.js` to the root of the package. This way we don't need to copy the file from `src` to `lib` at build time.
paul-marechal
force-pushed
the
cli-simple-bin
branch
from
ad0466b to
87f493b
Compare
Contributor
|
so a common pattern seems to be to place such scripts into a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves
ovsx.jsto the root of the package. This way we don't need to copy the file fromsrctolibat build time.