Activate content assist only when caret enters the viewer#2305
Activate content assist only when caret enters the viewer#2305iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
Conversation
SougandhS
force-pushed
the
DetailPaneFocusIssue
branch
2 times, most recently
from
f5f799f to
466d2b0
Compare
SougandhS
force-pushed
the
DetailPaneFocusIssue
branch
from
466d2b0 to
9d1780c
Compare
SougandhS
force-pushed
the
DetailPaneFocusIssue
branch
from
9d1780c to
78194b5
Compare
trancexpress
force-pushed
the
DetailPaneFocusIssue
branch
from
78194b5 to
d1196d5
Compare
|
@iloveeclipse I've validated the fix, content assist can no longer be invoked when editing a line in the Expressions view. I.e. we avoid showing non-sense suggestions there. For the new code, it looks OK to me. Can you also review it? |
SougandhS
force-pushed
the
DetailPaneFocusIssue
branch
from
d1196d5 to
7817cbf
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts content assist activation in the Variables/Expressions Detail Pane so the global Ctrl/Cmd+Space binding no longer incorrectly triggers the Detail Pane’s proposals while editing in the Expressions view.
Changes:
- Defers activation of the content assist handler until user interaction in the Detail Pane (caret movement).
- Deactivates the content assist handler when the Detail Pane’s text control loses focus.
- Updates copyright header year.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...pse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java
Outdated
Show resolved
Hide resolved
...pse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java
Outdated
Show resolved
Hide resolved
SougandhS
force-pushed
the
DetailPaneFocusIssue
branch
from
7817cbf to
ee1ba62
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...pse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java
Outdated
Show resolved
Hide resolved
...pse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java
Outdated
Show resolved
Hide resolved
SougandhS
force-pushed
the
DetailPaneFocusIssue
branch
from
ee1ba62 to
3a8ef92
Compare
|
unrelated test failure Edit: failure image |
Which one? Please check if it is known or not, and report it if not known yet. We should not ignore sporadic test failures. |
raised : #2544 |
iloveeclipse
force-pushed
the
DetailPaneFocusIssue
branch
from
3a8ef92 to
d187188
Compare
Content assist is now activated only when the caret moves inside the Detail Pane, preventing interference with Expressions View and Variables Views and enhancing the overall user experience. Fixes : eclipse-platform#2151
SougandhS
force-pushed
the
DetailPaneFocusIssue
branch
from
d187188 to
6b927c3
Compare
|
Another unrrelated failure see #2546 |
|
Thanks @iloveeclipse ! |
Fixes an issue where editing an expression in the Expressions view and pressing Ctrl/Cmd+Space caused the Detail Pane’s content assist to appear. The popup could not be dismissed normally and inserted no values when selected.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=543086
Content assist is now activated only when the caret moves inside the Detail Pane, preventing interference with the Expressions views and providing a more consistent UX.
Fixes : #2151