Remove dispose call for Colors in AntPreviewerUpdater #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akurtakov
force-pushed
the
remove_color_dispose_calls
branch
from
d03d4f3 to
722fd85
Compare
vogella
force-pushed
the
remove_color_dispose_calls
branch
from
722fd85 to
1dde711
Compare
akurtakov
force-pushed
the
remove_color_dispose_calls
branch
from
1dde711 to
afc419b
Compare
Member
|
There is a bit more to be cleaned up here. |
According to the Javadoc on Colors: * Colors do not need to be disposed, however to maintain compatibility * with older code, disposing a Color is not an error.
akurtakov
force-pushed
the
remove_color_dispose_calls
branch
from
afc419b to
941a3c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Javadoc on Colors: