-
-
Notifications
You must be signed in to change notification settings - Fork 23
Add validation to ensure es_type parameter is only used with effectsize = "boot"
#577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
strengejacke
merged 12 commits into
main
from
copilot/fix-24b719b9-3ed3-4b08-b811-c13fd992a99e
Oct 6, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
43ef485
Initial plan
Copilot cafab50
Add validation to ensure es_type only used with effectsize='boot'
Copilot cc1e795
Improve validation to also error when es_type used with effectsize=NULL
Copilot fbebfd3
Update R/estimate_contrasts.R [skip ci]
rempsyc d273af4
Update tests/testthat/test-estimate_contrasts_effectsize.R [skip ci]
rempsyc e73655e
Update tests/testthat/test-estimate_contrasts_effectsize.R [skip ci]
rempsyc 68d30a6
air because reviewdog is being really annoying right now
rempsyc 63a6934
spellcheck, wordlist
rempsyc f9d311b
Update R/estimate_contrasts.R
rempsyc f2ba8b3
air because of annoying dog
rempsyc 5ff532c
refactor
strengejacke db77b9b
air
strengejacke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move these checks into the function that computes the effect sizes,
.estimate_contrasts_effectsize().Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then we have a minor problem with the default
effectsize = NULL(withes_typestill specified) because then the checks get skipped and people will not see the error and therefore not understand whyes_typeis being ignored (or perceived as incorrect values):modelbased/R/estimate_contrasts.R
Lines 366 to 376 in f2ba8b3
There's another area of confusion. If people are not allowed to manually specify
es_type = "cohens.d"and be faced with the error, they might be confused as to why the defaultises_type = "cohens.d"nonetheless? So if we change the default toes_type = NULL, then we possibly resolve this ambiguity and also the above problem (so checks can stay within.estimate_contrasts_effectsize()).