Skip to content

Conversation

@etiennebacher
Copy link
Member

@etiennebacher etiennebacher commented Dec 17, 2024

easystats/easystats#434

@strengejacke anything to add or fix before 1.0.0? I think #561 can be in a future release

@strengejacke
Copy link
Member

Agree that #561 is probably not ready yet for release. The only thing that popped up recently and could be added might be an alternative method for rescale_weights(), see https://bsky.app/profile/bwiernik.bsky.social/post/3ld4hn44pgk2f.

If we decide to include this, rescale_weights() could get a method argument that returns current weights or those from the new method.

@etiennebacher etiennebacher marked this pull request as ready for review January 7, 2025 10:58
@etiennebacher
Copy link
Member Author

@strengejacke ok to release?

@etiennebacher
Copy link
Member Author

@strengejacke ?

@strengejacke
Copy link
Member

sorry, missed that. Yes!

@etiennebacher
Copy link
Member Author

Bunch of revdep failures: https://win-builder.r-project.org/incoming_pretest/datawizard_1.0.0_20250109_112755/reverseDependencies/summary.txt

Is everything expected? I don't understand why this didn't show up in the revdep workflow

@strengejacke
Copy link
Member

Yes, everything expected. Let me submit insight first, some of the newer features in other easystats-packages rely on changes in insight. datawizard will indeed break a lot of packages.

I think all our repos include Remotes: easystats/performance, easystats/parameters, easystats/datawizard, thus should be prepared for submission.

@easystats/maintainers Be prepared for CRAN mails when datawizard is accepted on CRAN.

@etiennebacher
Copy link
Member Author

Let me submit insight first, some of the newer features in other easystats-packages rely on changes in insight. datawizard will indeed break a lot of packages.

Ok, let me know when I can answer them

@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (416c1b0) to head (e806975).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   91.55%   91.55%   -0.01%     
==========================================
  Files          76       76              
  Lines        6193     6192       -1     
==========================================
- Hits         5670     5669       -1     
  Misses        523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke
Copy link
Member

insight is on CRAN.

@etiennebacher
Copy link
Member Author

On CRAN too

@etiennebacher etiennebacher merged commit c59c878 into main Jan 10, 2025
23 of 24 checks passed
@etiennebacher etiennebacher deleted the rc_datawizard_1.0.0 branch January 10, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants