doc(MethodTable): remove MethodTable component#7580
Merged
Conversation
Contributor
Reviewer's GuideRemoves the MethodTable documentation component from sample pages and their code-behind helpers, cleans up some sample component comments, and adds minor safety fixes to form validation demos. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7580 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 749 749
Lines 32976 32976
Branches 4580 4580
===========================================
+ Hits 32972 32976 +4
+ Misses 3 0 -3
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the MethodTable component and its associated usage across the codebase as specified in issue #7579. The changes include deletion of the MethodTable component files, removal of all GetMethods() functions that populated the component, and cleanup of related localization entries. Additionally, some null-safety improvements and comment cleanups are included.
Changes:
- Removed MethodTable component files (razor and code-behind)
- Removed GetMethods() functions from 15 sample component files
- Removed MethodTable localization entries from zh-CN.json and en-US.json
- Added null-conditional operators for FooForm and ComplexForm in ValidateForms.razor.cs
- Removed unused OnBeforeShowContextMenu method from Tabs.razor.cs
- Cleaned up XML documentation comments in several files
- Updated some comments to use
<inheritdoc/>for better documentation
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Locales/zh-CN.json | Removed Chinese localization for MethodTable component |
| src/BootstrapBlazor.Server/Locales/en-US.json | Removed English localization for MethodTable component |
| src/BootstrapBlazor.Server/Components/Samples/ValidateForms.razor.cs | Added null-conditional operators for defensive programming; removed GetMethods() |
| src/BootstrapBlazor.Server/Components/Samples/ValidateForms.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/Translators.razor.cs | Removed GetMethods() function |
| src/BootstrapBlazor.Server/Components/Samples/Translators.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/Tabs.razor.cs | Removed GetMethods() and unused OnBeforeShowContextMenu() |
| src/BootstrapBlazor.Server/Components/Samples/Tabs.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/Mermaids.razor.cs | Removed GetMethods() function |
| src/BootstrapBlazor.Server/Components/Samples/Mermaids.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/ListViews.razor.cs | Removed GetMethods(); updated comment to use inheritdoc |
| src/BootstrapBlazor.Server/Components/Samples/ListViews.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/JSRuntimeExtensions.razor.cs | Removed GetMethods() function |
| src/BootstrapBlazor.Server/Components/Samples/JSRuntimeExtensions.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/DragDrops.razor.cs | Removed GetMethods(); updated comment to use inheritdoc; removed XML doc comments from private methods |
| src/BootstrapBlazor.Server/Components/Samples/DragDrops.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/Clipboards.razor.cs | Removed GetMethods() function |
| src/BootstrapBlazor.Server/Components/Samples/Clipboards.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/Charts/Index.razor.cs | Removed GetMethodAttributes() function |
| src/BootstrapBlazor.Server/Components/Samples/Charts/Index.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/Captchas.razor.cs | Removed GetMethods() and GetEvents(); removed XML doc comments from private methods |
| src/BootstrapBlazor.Server/Components/Samples/Captchas.razor | Removed both MethodTable and EventTable usage |
| src/BootstrapBlazor.Server/Components/Samples/Buttons.razor.cs | Removed GetMethods() and GetEvents(); removed XML doc comment from private method |
| src/BootstrapBlazor.Server/Components/Samples/Buttons.razor | Removed both MethodTable and EventTable usage |
| src/BootstrapBlazor.Server/Components/Samples/BrowserFingers.razor.cs | Removed GetMethods() function |
| src/BootstrapBlazor.Server/Components/Samples/BrowserFingers.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Samples/Ajaxs.razor.cs | Removed GetMethods() function |
| src/BootstrapBlazor.Server/Components/Samples/Ajaxs.razor | Removed MethodTable usage |
| src/BootstrapBlazor.Server/Components/Components/MethodTable.razor.cs | Deleted component code-behind file |
| src/BootstrapBlazor.Server/Components/Components/MethodTable.razor | Deleted component markup file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -157,7 +157,3 @@ | |||
| </DemoBlock> | |||
|
|
|||
| <AttributeTable Type="typeof(Button)" /> | |||
There was a problem hiding this comment.
This PR removes both EventTable and MethodTable references from this file. However, the PR title and linked issue #7579 only mention removing the MethodTable component. The removal of EventTable and the GetEvents method appears to be outside the scope of this PR. Consider either updating the PR description to reflect the additional changes or creating a separate PR for EventTable removals.
| @@ -18,7 +18,3 @@ | |||
| </DemoBlock> | |||
|
|
|||
| <AttributeTable Type="typeof(Captcha)" /> | |||
There was a problem hiding this comment.
This PR removes both EventTable and MethodTable references from this file. However, the PR title and linked issue #7579 only mention removing the MethodTable component. The removal of EventTable and the GetEvents method appears to be outside the scope of this PR. Consider either updating the PR description to reflect the additional changes or creating a separate PR for EventTable removals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7579
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the MethodTable documentation component and its usages from sample pages while simplifying related sample code.
Enhancements: