Improve ButtonDarkModeAdapter color handling and remove inappropriate HighContrast logic#14161
Open
LeafShi1 wants to merge 1 commit intodotnet:mainfrom
Open
Conversation
… HighContrast logic
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14161 +/- ##
===================================================
+ Coverage 77.15180% 77.15415% +0.00235%
===================================================
Files 3279 3279
Lines 645333 645325 -8
Branches 47720 47718 -2
===================================================
+ Hits 497886 497895 +9
+ Misses 143754 143735 -19
- Partials 3693 3695 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14155
Proposed changes
UseVisualStyleBackColoris false or custom colors are setIsHighContrastHighlighted()checks from bothGetButtonTextColorandGetButtonBackColormethods, allowing the adapter to focus solely on Dark Mode renderingControl.ShouldSerializeBackColor()andControl.ShouldSerializeForeColor()to accurately detect when users have explicitly set color propertiesCustomer Impact
UseVisualStyleBackColoris set to false, buttons now maintain a consistent background color and no longer change appearance on hover/press states.Regression?
Risk
Screenshots
Before
DarkModeResults.mp4
After
AfterChanges.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow