Fix Get-GitRepoRoot type inconsistency causing empty string return from subdirectories#51738
Closed
Copilot wants to merge 2 commits intoadegeo/skillsfrom
Closed
Fix Get-GitRepoRoot type inconsistency causing empty string return from subdirectories#51738Copilot wants to merge 2 commits intoadegeo/skillsfrom
Copilot wants to merge 2 commits intoadegeo/skillsfrom
Conversation
Co-authored-by: adegeo <67293991+adegeo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix repository root handling in skills and prompts addition
Fix Get-GitRepoRoot type inconsistency causing empty string return from subdirectories
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Get-GitRepoRootfunction had a type inconsistency bug that returned an empty string when executed from subdirectories, though it worked correctly from the repository root.Root Cause
Get-Locationreturns aPathInfoobject, whileSplit-Pathreturns a string. After the first loop iteration:When
.gitis found in a subsequent iteration,return $currentPath.Pathattempts to access the.Pathproperty on a string, which returns an empty string instead of failing.Changes
$currentPathas a string:$currentPath = (Get-Location).Path$currentPathdirectly instead of$currentPath.PathThis ensures the function returns the correct repository root path regardless of the working directory depth.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.