Migrate AddKeepAlivesStep from ILLink custom step#10837
Draft
Conversation
…Pipeline Move AddKeepAlivesStep out of the ILLink trimmer pipeline so it runs in the post-ILLink AssemblyModifierPipeline instead. This removes the dual-compilation (#if ILLINK) pattern and simplifies the step to only implement IAssemblyModifierPipelineStep. - Remove AddKeepAlivesStep from Microsoft.Android.Sdk.ILLink.csproj - Remove _TrimmerCustomSteps registration in TypeMap.LlvmIr.targets - Add AddKeepAlives property and step to AssemblyModifierPipeline - Pass AddKeepAlives to AssemblyModifierPipeline in Common.targets - Remove duplicate property/step from LinkAssembliesNoShrink (now inherited from base class)
7 tasks
Member
Author
|
Needs the fixes from #10695 to avoid modifying assemblies in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves AddKeepAlives to assembly modifier pipeline.
This may depend on some fixes I'm working on in #10695.