Introduce Logging package and rework official pipelines by cheenamalhotra · Pull Request #3967 · dotnet/SqlClient

cheenamalhotra · 2026-02-19T18:17:25Z

Summary

Moves the ETW SqlClientEventSource tracing infrastructure (~1,180 lines) from the core driver into a new Microsoft.Data.SqlClient.Extensions.Logging (netstandard2.0) NuGet package. This enables independent versioning and shared use across SqlClient and the AKV provider (which had its own AKVEventSource, now deleted).

Key Changes

Area	What Changed
New package	`Microsoft.Data.SqlClient.Extensions.Logging` — contains `SqlClientEventSource`, `SqlClientMetrics`, `SqlClientEventScope`, and scope types
Core driver	`SqlClientEventSource.cs` reduced to a ~43-line `SqlClientDiagnostics` bridge; 28 source files updated from `TryEventScope`/`TrySNIEventScope` → `SqlClientEventScope`
AKV provider	Deleted `AKVEventSource.cs`; AKV now uses the shared `SqlClientEventSource.Log` from the Logging package
Build	`build.proj` gains Logging targets; nuspec files add Logging dependency across all TFMs
Pipelines	Consolidated into unified OneBranch official/non-official pipelines with selective build params, approval service, ESRP signing for Logging, reusable publish job with dry-run; deleted 9 standalone pipeline/variable files
Docs	Added `PackageReadme.md` for all 6 packages; new OneBranch pipeline design spec (522 lines); updated `AGENTS.md`

Checklist

No breaking changes — logging behavior preserved via the extracted package as a dependency

…gned DLLs).

Copilot

Pull request overview

Copilot reviewed 121 out of 122 changed files in this pull request and generated 2 comments.

Directory.Packages.props

build.proj

Copilot

Pull request overview

Copilot reviewed 121 out of 122 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 125 out of 126 changed files in this pull request and generated 3 comments.

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

eng/pipelines/steps/compound-esrp-dll-signing-step.yml

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

- Replaced copy scripts with CopyFiles@2 tasks.

mdaigle

It may work as a whole, but this is a tough one to review because there are so many ideas combined into one changeset. I'd really like to see pieces broken out so that they can be effectively reviewed.

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

eng/pipelines/common/templates/steps/configure-sql-server-step.yml

eng/pipelines/jobs/pack-logging-package-ci-job.yml

src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/PackageReadme.md

src/Microsoft.SqlServer.Server/PackageReadme.md

- Fixed inconsistent/inaccurate official pipeline variable names.

Copilot

Pull request overview

Copilot reviewed 124 out of 125 changed files in this pull request and generated no new comments.

- Addressed some of the stub parameter comments.

Copilot

Pull request overview

Copilot reviewed 131 out of 132 changed files in this pull request and generated no new comments.

- Fixed ApiScan file copying for SqlClient. - Removed some unused parameters, variables, and files.

src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj

paulmedynski · 2026-02-23T14:01:15Z

src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj

    <DebugSymbols>true</DebugSymbols>
  </PropertyGroup>

+  <!--


I replaced the old .nuspec with this. Now we can use the standard C# project targets and pipeline jobs/steps.

mdaigle · 2026-02-23T17:54:10Z

I think all of my comments are addressed. I'll be looking at the pipelines directly now to make sure everything looks good.

paulmedynski · 2026-02-23T17:54:27Z

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

+
 parameters:
+  # The directory to copy PDB files into for ApiScan to inspect.
  - name: symbolsFolder


@paulmedynski These 2 parameters aren't necessary now that we're defining the ob_sdl_apiscan variables below.

paulmedynski · 2026-02-23T17:54:54Z

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

    type: windows  # read more about custom job pool types at https://aka.ms/obpipelines/yaml/jobs

  variables:
-  - template: /eng/pipelines/libraries/variables.yml@self


This is already imported by our caller.

paulmedynski · 2026-02-23T18:01:43Z

eng/pipelines/steps/compound-esrp-dll-signing-step.yml

 #################################################################################

 parameters:
+  # App Registration Client Id.


@paulmedynski These docs aren't very useful.

paulmedynski · 2026-02-23T18:02:27Z

eng/pipelines/steps/compound-esrp-nuget-signing-step.yml

 #################################################################################

 parameters:
+  # App Registration Client Id.


@paulmedynski Docs not useful.

src/Microsoft.Data.SqlClient.Extensions/Azure/src/AzureVersions.props

cheenamalhotra added 30 commits February 19, 2026 09:55

Initialize Logging package

88b5e91

Update Event Scope type names

ed287b5

Include Logging in package ref

f49e21a

Cleanup pipelines, add non-official as well

9a412a8

Include SNK signing key

c629a27

Rename pipeline

8aba060

Fix keywords

8c14916

Fix pipelines to not release if no release job is selected

4ae5f15

Notification based release stage + fix build number format

8b4ab2e

Conditional execution

991e2af

Add back the revision number decimal

2a20bcd

Update ESRP version + split build number

f1a52b6

Fix the build job to build and pack separately (as we need to pack si…

a5518e6

…gned DLLs).

Fix for APIScan failure, ensure DLLs are copied first.

7c651a4

Include readme files in NuGet packages

2f60302

Fix APIScan issue

0a19676

Fix build error and APIScan errors

69b55b5

download packages before building dependent packages

8c3a2b0

Fix azure project build by providing abstractions package version

f95382a

Rename file to Readme in all packages

e86f3f1

Enable APIScan and include instructions for onebranch pipelines.

0507f98

Pass effective logging package version to AKV build

eecfc11

Fix

71fa038

Include ob_outputDirectory variable, and other fixes

8fc0ec4

Implement approval service

95a1e5b

Configure ob_release params for approval service

24b64f7

Skip building packages when not requested.

c3f9d85

Split environments (prod v/s non-prod)

648a3e6

Touch-ups to job names

2f7a410

Fix release stage to be deployment job

2cedac3

Copilot AI review requested due to automatic review settings February 20, 2026 17:22

Copilot started reviewing on behalf of paulmedynski February 20, 2026 17:23 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

Directory.Packages.props Outdated Show resolved Hide resolved

build.proj Outdated Show resolved Hide resolved

paulmedynski added 2 commits February 20, 2026 13:45

Fixed missing assemblyBuildNumber argument.

a8f5bb2

Fixed another missing assemblyBuildNumber.

6e02918

Copilot AI review requested due to automatic review settings February 20, 2026 17:49

Copilot started reviewing on behalf of paulmedynski February 20, 2026 17:49 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

paulmedynski added 2 commits February 20, 2026 14:27

Fixed expression variable expansion of build number.

569c902

Fixed reflection bug in the tests.

3f35416

Copilot AI review requested due to automatic review settings February 20, 2026 19:25

Copilot started reviewing on behalf of paulmedynski February 20, 2026 19:26 View session

Fixed stage name typo.

cbaf0f6

Copilot AI reviewed Feb 20, 2026

View reviewed changes

eng/pipelines/common/templates/jobs/build-signed-package-job.yml Outdated Show resolved Hide resolved

eng/pipelines/steps/compound-esrp-dll-signing-step.yml Outdated Show resolved Hide resolved

eng/pipelines/common/templates/jobs/build-signed-package-job.yml Show resolved Hide resolved

- Removed redundant SqlServer package templates.

e475f86

- Replaced copy scripts with CopyFiles@2 tasks.

mdaigle requested changes Feb 20, 2026

View reviewed changes

- Removed special build/pack setup for SqlServer package.

c3b9941

- Fixed inconsistent/inaccurate official pipeline variable names.

Copilot AI review requested due to automatic review settings February 22, 2026 22:09

Copilot started reviewing on behalf of paulmedynski February 22, 2026 22:10 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

paulmedynski added 2 commits February 23, 2026 10:07

Lots of changes related to PR comments.

7016397

- Fixing dotnet pack tasks.

925e438

- Addressed some of the stub parameter comments.

Copilot AI review requested due to automatic review settings February 23, 2026 15:08

Copilot started reviewing on behalf of paulmedynski February 23, 2026 15:09 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

- Added symbols publishing to packages using the common jobs.

b5232d3

- Fixed ApiScan file copying for SqlClient. - Removed some unused parameters, variables, and files.

mdaigle requested changes Feb 23, 2026

View reviewed changes

src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj Show resolved Hide resolved

paulmedynski reviewed Feb 23, 2026

View reviewed changes

paulmedynski requested changes Feb 23, 2026

View reviewed changes

Comments

Conversation

cheenamalhotra commented Feb 19, 2026

Summary

Key Changes

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdaigle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

paulmedynski Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

mdaigle commented Feb 23, 2026

Uh oh!

paulmedynski Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

paulmedynski Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

paulmedynski Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

paulmedynski Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants