[3.0] Improve handling of nested struct names and affixes#2555
Draft
Exanite wants to merge 25 commits intodotnet:develop/3.0from
Draft
[3.0] Improve handling of nested struct names and affixes#2555Exanite wants to merge 25 commits intodotnet:develop/3.0from
Exanite wants to merge 25 commits intodotnet:develop/3.0from
Conversation
Considering we decided to follow Microsoft's Framework Design Guidelines (acronym threshold of 2) for the bindings and rest of the API, might as well be consistent here.
… separation hack (no longer necessary)
…mbers are normalized
This lets us handle prefixing and prettification separately, which notably is important if we add prefixes after prettification. We want to prefix the final name, not the intermediate name in this case.
…igured (cherry picked from commit bc94260)
…ous that it is not the last trimmer
This no longer makes sense to keep and enabling features by baseline version seems fiddly. If we need to toggle features for newer versions, we can explicitly add a boolean config option.
Exanite
force-pushed
the
feature/nested-struct-name-affixes
branch
from
2693e05 to
adf4eee
Compare
…essor and ReapplyAffixesNameProcessor
Kinda a cop out decision, but it keeps thing simple (and thus maintainable) and implementing it fully seems overkill for what we need.
… for function pointer types are named
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
(WIP)
Nested struct names are an edge case in the name affix system because they have the following format:
Currently, nested struct names are generated by directly combining the full parent type name with the full field name.
This leads to issues where the ParentSuffix is not handled correctly.
For example,
PerformanceCounterDescriptionArmNameshould bePerformanceCounterDescriptionARMName.Related issues, Discord discussions, or proposals
Original discussion: https://discord.com/channels/521092042781229087/587346162802229298/1460017726813900975
Further Comments
Tasks
PerformanceCounterDescriptionArmNameshould bePerformanceCounterDescriptionARMNameExtractNestedTypingandTransformHandlesinto a new set ofExtract-mods.ExtractNestedTyping, but forTransformHandlesit is useful forAddApiProfilesto be executed after all types are extracted, but not yet transformed.TransformHandlesintoTransformHandlesandExtractHandlesExtractNestedTypingINameTrimmer.Order/Versionissue (we don't want magic numbers) and consider removingINameTrimmerentirely.INameTrimmertoINameProcessorand update names where relevant