feat(style-editor): Improve empty state for style editor #34471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…palette ### Changes Made - Replaced the placeholder message in the style editor palette with a new component. - Added HTML, SCSS, and TypeScript files for the new empty state component to enhance user experience when no styles are available. - Updated the language properties to include a message for the empty state. ### Motivation This update improves the user interface by providing a more informative and visually appealing empty state when no styles are present, guiding users on how to start styling their
1 task
1 task
### Changes Made - Introduced a new empty state component for the style editor palette to enhance user experience when no styles are available. - Added corresponding HTML, SCSS, and TypeScript files for the new component. - Updated the component imports to ensure proper functionality. ### Motivation This update provides a visually appealing and informative empty state, guiding users on how to start styling when no styles are present.
![semgrep-code-dotcms-test[bot]](https://avatars.githubusercontent.com/u/1005263?s=60&v=4){kind=small}
...te/components/dot-uve-style-editor-empty-state/dot-uve-style-editor-empty-state.component.ts
Show resolved
Hide resolved
|
Semgrep found 1
Risk: Affected versions of @angular/compiler and @angular/core are vulnerable to Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting'). Angular's template compiler fails to classify the Fix: Upgrade this library to at least version 20.3.16 at core/core-web/yarn.lock:512. Reference(s): GHSA-jrmj-c5cx-3cw6, CVE-2026-22610 If this is a critical or high severity finding, please also link this issue in the #security channel in Slack. |
...te/components/dot-uve-style-editor-empty-state/dot-uve-style-editor-empty-state.component.ts
Show resolved
Hide resolved
KevinDavilaDotCMS
requested review from
adrianjm-dotCMS,
dario-daza,
fmontes,
hmoreras,
nicobytes,
oidacra,
rjvelazco and
zJaaal
oidacra
reviewed
Feb 2, 2026
.../components/dot-uve-style-editor-empty-state/dot-uve-style-editor-empty-state.component.scss
Outdated
Show resolved
Hide resolved
oidacra
approved these changes
Feb 2, 2026
### Changes Made - Added a new effect to reset the active contentlet when the page is unlocked, preventing editing conflicts. - Updated the component's TypeScript file to include logic for handling the active contentlet state based on the page's lock status. - Enhanced unit tests to verify the new behavior of resetting the active contentlet under specified conditions. ### Motivation This update improves the user experience by ensuring that when a page is unlocked, any active contentlet selection is cleared, reducing the risk of editing conflicts.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the user experience of the style editor palette by replacing a simple text placeholder with a dedicated empty state component. The change provides a more polished and informative UI when no contentlet is selected or when the selected contentlet doesn't have a style editor schema.
Changes:
- Created a new
DotUveStyleEditorEmptyStateComponentwith an icon, formatted message, and documentation link - Added a language property key with HTML content for the empty state message
- Integrated the empty state component into the palette, replacing inline placeholder text
- Added an effect to reset active contentlet when a page is unlocked (unrelated feature)
- Updated SDK README documentation with type corrections and table formatting fixes (unrelated cleanup)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
Language.properties |
Added new language key for style editor empty state message with HTML link |
core-web/libs/sdk/uve/README.md |
Fixed table formatting and corrected type names in documentation examples |
edit-ema-editor.component.ts |
Added effect to reset active contentlet on page unlock with corresponding tests |
edit-ema-editor.component.spec.ts |
Added comprehensive tests for the unlock/reset contentlet behavior |
dot-uve-palette.component.ts |
Imported new empty state component |
dot-uve-palette.component.html |
Replaced inline placeholder with empty state component |
dot-uve-style-editor-empty-state.component.* |
New empty state component with TypeScript, HTML template, and SCSS styling |
...te/components/dot-uve-style-editor-empty-state/dot-uve-style-editor-empty-state.component.ts
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Show resolved
Hide resolved
### Changes Made - Refactored HTML structure in the empty state component for better readability. - Enhanced SCSS styles by removing unnecessary rules and optimizing class definitions. - Updated the language properties to include a target attribute in the Learn more link for improved accessibility. ### Motivation These changes improve the maintainability of the empty state component and enhance user experience by ensuring links open in a new tab, providing clearer guidance on styling options.
dario-daza
reviewed
Feb 3, 2026
.../dot-uve-palette/components/dot-uve-style-editor-form/dot-uve-style-editor-form.component.ts
Outdated
Show resolved
Hide resolved
dario-daza
approved these changes
Feb 3, 2026
nicobytes
approved these changes
Feb 3, 2026
KevinDavilaDotCMS
deleted the
34470-task-improve-empty-state-on-style-editor-palette
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2026-02-02.12-20-37.mov
Changes Made
This PR fixes: #34470
This PR fixes: #34470