-
Notifications
You must be signed in to change notification settings - Fork 209
Add evaluation framework with Docker isolation #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
commented
Jan 8, 2026
Member
Author
dgageot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's improve the code!
pkg/evaluation/eval.go
Outdated
| ) | ||
|
|
||
| // GenerateRunName creates a memorable name for an evaluation run. | ||
| func GenerateRunName() string { |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract this to its own file
- Run evaluations in isolated Docker containers with Docker-in-Docker - Support concurrent evaluation runs with configurable parallelism - Generate memorable run names (e.g., swift-falcon-042) - Save results to JSON file and debug log in <evals-dir>/results/ - Check response size, tool calls, handoffs, and relevance criteria - Use judge model (configurable) for relevance checking - Show progress bar with colored output and per-evaluation results - Exclude errored evaluations from summary totals - Add comprehensive debug logging for troubleshooting Assisted-By: cagent
rumpl
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assisted-By: cagent