Fix race conditions #1310
Closed
Fix race conditions #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper synchronization for global telemetry variables and Client.version field to prevent races between: - SetGlobalTelemetryVersion writing globalTelemetryVersion - EnsureGlobalTelemetryInitialized reading globalTelemetryVersion - SetGlobalTelemetryVersion writing Client.version - performHTTPRequest and createEvent reading Client.version Changes: - Add globalMu RWMutex to protect globalTelemetryVersion and globalTelemetryDebugMode - Add setVersion/getVersion methods to Client for thread-safe version access - Pass version as parameter to performHTTPRequest to avoid deadlock Assisted-By: cagent
Add mutex synchronization to mockSource struct to prevent races between: - Test goroutine modifying data/err fields - Background refresh goroutine reading data/err fields Added thread-safe accessor methods: - setData() for updating mock data - setErr() for updating mock error - getReadCount() for reading call count Assisted-By: cagent
Add mutex synchronization to queueProvider.CreateChatCompletionStream to prevent races when multiple goroutines access the streams slice. Use index-based tracking instead of slice mutation for thread safety. Assisted-By: cagent
Add RWMutex synchronization to Session struct to prevent races between: - AddMessage writing to Messages slice - GetAllMessages reading from Messages slice - GetMessages reading from Messages slice This race was detected when the title generator goroutine calls GetLastUserMessageContent() while the main runtime loop is adding messages. Changes: - Add mu sync.RWMutex field to Session struct - Protect AddMessage and AddSubSession with Lock() - Protect GetAllMessages with RLock() - Protect s.Messages access in GetMessages with RLock() Assisted-By: cagent
Assisted-By: cagent
Signed-off-by: David Gageot <[email protected]>
krissetto
reviewed
Jan 7, 2026
| } | ||
|
|
||
| // getAllMessagesLocked extracts all messages without acquiring the lock (caller must hold lock) | ||
| func (s *Session) getAllMessagesLocked() []Message { |
Contributor
There was a problem hiding this comment.
are there any scenarios where we want to call this func without the caller having acquired the lock beforehand?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected with: