Replaced the deprecated optparse with argparse#5
Open
mdxs wants to merge 1 commit intodingari:masterfrom
Open
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards Python 3 compatibility (see #4), this PR replaces the use of the
optparsemodule (deprecated since Python 3.2) with theargparsemodule available in both Python 2 and 3. The command line interface has also been expanded with more detail (seepython dfu.py --helpfor details).In the process made the address argument mandatory and more flexible (by adding a parsing/normalizing method for MAC-addresses to the project's
util.py).Please do check whether the tool still works, I've separated this PR out from more future changes; but lacked time to properly test all aspects.